Upgrade python to 3.13 #3911
Upgrade python to 3.13 #3911
Conversation
|
jamshale
force-pushed
the
python-3.13
branch
from
37b6d45 to
2340c8e
Compare
jamshale
force-pushed
the
python-3.13
branch
2 times, most recently
from
c0b8841 to
2cdab0b
Compare
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the Python version from 3.12 to 3.13 across the entire ACA-Py (Aries Cloud Agent - Python) project. The upgrade touches configuration files, Docker images, CI/CD pipelines, documentation, and includes code changes to maintain compatibility with Python 3.13.
Key Changes:
- Updated Python version specification from
^3.12to^3.13in pyproject.toml - Upgraded
propcachedependency from 0.4.0 to 0.4.1 and added it as an explicit dependency - Added
list()conversions in anoncreds code for iterating over database query results - Removed conditional
typing-extensionsdependency markers for Python < 3.13 - Replaced
web.pyPyPI package with Git installation in demo Dockerfile for Python 3.13 compatibility - Changed
pysqlcipher3tosqlcipher3-wheelsin Docker build
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| sonar-project.properties | Updates Sonar Python version configuration to 3.13 |
| pyproject.toml | Changes Python dependency to ^3.13 and adds explicit propcache dependency |
| poetry.lock | Updates lock file with new dependency versions, removes Python < 3.13 conditional dependencies |
| docs/readthedocs.yaml | Updates ReadTheDocs build to use Python 3.13 |
| docs/features/devcontainer.md | Updates documentation reference from Python 3.12 to 3.13 |
| docker/Dockerfile.test | Updates base image to python:3.13-slim-bookworm, removes python_version ARG |
| docker/Dockerfile.run | Updates base image to python:3.13-slim-bookworm, removes python_version ARG |
| docker/Dockerfile.demo | Rebuilds from python:3.13 base, adds Git installation of web.py, removes user chown |
| docker/Dockerfile | Updates default python_version ARG to 3.13, replaces pysqlcipher3 with sqlcipher3-wheels |
| demo/requirements.txt | Removes web.py~=0.62 (moved to Git installation in Dockerfile) |
| demo/playground/examples/Dockerfile.test.runner | Updates to python:3.13-slim |
| acapy_agent/anoncreds/revocation/revocation.py | Adds list() conversion for database query results in two locations |
| acapy_agent/anoncreds/issuer.py | Adds list() conversion for database query results in two locations |
| README.md | Updates Python version badge from 3.12 to 3.13 |
| .readthedocs.yaml | Updates ReadTheDocs Python version to 3.13 |
| .github/workflows/*.yml | Updates all GitHub Actions workflows to use Python 3.13 |
| .devcontainer/* | Updates devcontainer configuration to use Python 3.13 |
Comments suppressed due to low confidence (1)
docker/Dockerfile.demo:42
- Installing
web.pyfrom the GitHub repository appears to be a workaround for Python 3.13 compatibility since the PyPI version was removed from demo/requirements.txt. Consider documenting why this specific installation method is needed, or better yet, wait for an official PyPI release that supports Python 3.13. Installing directly from Git repositories can lead to reproducibility issues and makes it harder to track which version is actually being used.
RUN pip3 install git+https://github.com/webpy/webpy.git
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Just a note: once this is merged, there is a Ruff lint category that can be selected: "UP". It helps to automatically upgrade python syntax to abide by a target version. So we can later add to the pyproject.toml: [tool.ruff]
target-version = "py313"
lint.select = [
"UP", # pyupgrade (upgrade syntax)
]And then Just mentioning because it's a nice lil feature for that to be done automatically. |
Signed-off-by: JamieHale <jamiehalebc@gmail.com>
Signed-off-by: JamieHale <jamiehalebc@gmail.com>
…ub repo Signed-off-by: JamieHale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
jamshale
force-pushed
the
python-3.13
branch
from
09f9df0 to
e9daa27
Compare
Signed-off-by: jamshale <jamiehalebc@gmail.com>
|
|
This is updated with main. I removed the non python 3.13 compatible webpy library from the demo container. I'm not sure what this was for previously, but it isn't referenced anywhere in the project. Oddly, it installed earlier? |
|
@esune This and the plugin repo PR have been updated and need a new approval. |
3 participants
This should be ready to go now. It basically does the things required to upgrade to python 3.13. A few key points.
The plugins all need to be upgraded with acapy core. The corresponding PR is here. openwallet-foundation/acapy-plugins#2504. It can have it's acapy ref updated and be merged after this.
The Interop tests are failing because the test harness project needs to have python upgraded. Will do this later.